Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle http errors when probing repositories #618

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix: handle http errors when probing repositories #618

merged 2 commits into from
Jan 28, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 24, 2025 •
edited
Loading

Fixes #613.

/deploy #notest

@leafty leafty temporarily deployed to renku-ci-ds-618 January 24, 2025 12:13 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-618.dev.renku.ch

@coveralls
Copy link

coveralls commented Jan 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12951340318

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 86.562%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/error_handler.py 1 89.47%
components/renku_data_services/secrets/db.py 3 92.68%
Totals Coverage Status
Change from base Build 12884705401: 0.04%
Covered Lines: 15383
Relevant Lines: 17771
💛 - Coveralls

@leafty leafty marked this pull request as ready for review January 24, 2025 14:15
@leafty leafty requested a review from a team as a code owner January 24, 2025 14:15
@leafty leafty enabled auto-merge (squash) January 24, 2025 14:15
@leafty leafty merged commit fefdb01 into main Jan 28, 2025
21 of 24 checks passed
@leafty leafty deleted the leafty/fix-613 branch January 28, 2025 09:22
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle DNS failure for repository probes
4 participants
@leafty @RenkuBot @coveralls @olevski